add test coverage for cross-folder list scenarios#1146
Merged
Conversation
Contributor
labkey-nicka
left a comment
labkey-nicka
left a comment
There was a problem hiding this comment.
This is looking good. Just a few minor improvements. Glad to have a test we add additional coverage to as we continue to build out this feature set.
|
|
||
|
|
||
| @Category({}) | ||
| public class CrossfolderListTest extends BaseWebDriverTest |
Contributor
There was a problem hiding this comment.
nit: To be consistent with our other "cross-folder" tests I would change this test class/file/project name to CrossFolderListTest.
| import org.junit.BeforeClass; | ||
| import org.junit.Test; | ||
| import org.junit.experimental.categories.Category; | ||
| import org.labkey.data.xml.queryCustomView.FilterType; |
| import static org.junit.Assert.assertNotNull; | ||
|
|
||
|
|
||
| @Category({}) |
Contributor
There was a problem hiding this comment.
I think we should make this @Category align with the ListTest. @labkey-tchad would have a better idea of exactly what to set it to. Something like:
@Category({Daily.class, Data.class, Hosting.class})| new HashSet(bottomStrings), new HashSet(subfolderPage.getGrid().getColumnDataAsText("String Column"))); | ||
| } | ||
|
|
||
| private ListDefinition makeListDef(String listName, List<FieldDefinition> listColumns) |
Contributor
There was a problem hiding this comment.
nit: We don't tend to use the verb make in function/method names. I would recommend renaming to createListDef or getListDef.
labkey-nicka
approved these changes
Jun 27, 2022
DariaBod
added a commit
that referenced
this pull request
May 13, 2026
#### Rationale Interactions with icon elements on the page to catch GitHub Issue 1146. #### Related Pull Requests - LabKey/labkey-ui-components#1999 - LabKey/labkey-ui-premium#950 - #2984 - LabKey/platform#7653 - LabKey/limsModules#2185 #### Changes - <!-- list of descriptions of changes that are worth noting (replace this comment) -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This adds some test coverage for list behavior in cross-container scenarios
Related Pull Requests
n/a
Changes
adds a new test
updates LabkeyErrorPage to wait for error heading to be present